-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor install script #114
Merged
TheJaredWilcurt
merged 38 commits into
nwjs:master
from
ayushmanchhabra:refactor/install
Oct 7, 2023
Merged
Refactor install script #114
TheJaredWilcurt
merged 38 commits into
nwjs:master
from
ayushmanchhabra:refactor/install
Oct 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushmanchhabra
commented
Oct 3, 2023
ayushmanchhabra
commented
Oct 3, 2023
…rsion from the version manifest anyway
For consistency.
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
…into refactor/install
Added some more comments, did not run locally. |
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Co-authored-by: The Jared Wilcurt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #109
Closes: #93
Closes: #77
Closes: #74
Closes: #26
Description
download
tonode:https
for handling downloadsdecompress
tocompressing
to handle decompressionrimraf
tonode:fs
'srm -rf
function call.file-exists
tonode:fs
'sexistsSync
progress
tocli-progress